Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/footer #698

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Feature/footer #698

merged 5 commits into from
Sep 18, 2024

Conversation

EdoStorm96
Copy link
Contributor

A little footer, based on what we had. I don´t know if we want any other text or features from this? It seems fine like this imo.

Also went ahead and removed WMOCheck. One more issue ;p

This was linked to issues Sep 11, 2024
@EdoStorm96
Copy link
Contributor Author

I've also just added a fix for #690 to this PR. Very minor change.

@EdoStorm96 EdoStorm96 linked an issue Sep 17, 2024 that may be closed by this pull request
Copy link
Contributor

@miggol miggol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like that this now stretches the page nicely in the vertical direction. All seems well here.

@EdoStorm96 EdoStorm96 merged commit aac644a into major/4 Sep 18, 2024
3 checks passed
@EdoStorm96 EdoStorm96 deleted the feature/footer branch September 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add footer Change logic for DMPFileSection in pdf_diff_logic Figure out where WMOCheck is used
2 participants